Re: two server crashing bugs

I wrote:

>       The other bug is in the rfrac() function. The function casts its
> return value to DFLOAT (float on Unix-like systems), potentially making
> the value equal to 1.0 (this happens if randomMT() returns a value greater
> or equal to 0xffffff80). The problem with this is that rfrac() is
> often used to obtain a random index for an array, gradually leading to
> server memory corruption, and a crash.

Hi.
        Jean-Yves Lefort (Decadix) informed me that the patch I've made
for XPilot 4.5.4 did not work as intended. The problem with it was that
the rfrac() function was changed to return double, but the new prototype
for rfrac() was not included in some c-files, which caused the compiled
code to malfunction.

        I've made a new patch for XPilot 4.5.4, which fixes the "get" and
the "rfrac" bugs and a few other minor bugs and compiler warnings.

http://xpilot.sourceforge.net/patches/454fix.diff

Sorry for any inconvenience,
Kristian Söderblom